Remove test dependency on HypothesisTests #1311
Merged
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
=======================================
Coverage 81.58% 81.58%
=======================================
Files 115 115
Lines 6651 6651
=======================================
Hits 5426 5426
Misses 1225 1225 Continue to review full report at Codecov.
|
johnczito
approved these changes
Apr 22, 2021
Member
|
Thanks! I somehow convinced myself at the time that this wouldn't happen if it was just a test dependency. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the test dependency on HypothesisTests.jl and instead uses a custom implementation of the KS test.
The reason for this change is that HypothesisTests.jl introduces a circular dependency: it depends on Distributions.jl and therefore tests fail if a breaking release is prepared (see e.g. #1308 (comment)).