-
Notifications
You must be signed in to change notification settings - Fork 64
Doc alternative space array package #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[skip ci]
|
In the docs, I couldn't press the edit, to well edit, and the search in the codebase wasn't helpful, then I remembered moved to stdlib. Maybe something can be done about that, for the link and/or doc better. I found Jutho's package in discourse thread. I'm assuming it works well, at least it's good to know of, and limitations in stdlib should be doced anyway. I don't know if it's the best one (or e.g. as good as Python's sparse), I found other packages thay may not actually be related: https://juliahub.com/ui/Packages/LuxurySparse/4Qz8z/0.6.1 |
|
https://sparsearrays.juliasparse.org/dev/#Noteworthy-external-packages Should put it here. But that's a great call out I can't believe I missed SparseArrayKit. LuxurySparse might be a good inclusion, but I'm not sure how impactful it is outside of the Yao ecosystem. |
[skip ci]
|
Fantastic! While I'm not sure what is unique about the LuxurySparse package the other two (ExtendableSparse and SparseArrayKit) should at least have a little description. After that we're good to merge! |
|
LuxurySparse has some additional types so I added it too, and one more that seemed helpful. I would argue for merging the original commit too, as it clarifies limitation, or at least that part if you do not want to link to a package there. You could however add to that, "see package below" (maybe with a link to that section). |
Co-authored-by: Will Kimmerer <[email protected]>
Co-authored-by: Will Kimmerer <[email protected]>
Co-authored-by: Will Kimmerer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 34.25% 34.24% -0.02%
==========================================
Files 25 25
Lines 21127 21127
==========================================
- Hits 7238 7235 -3
- Misses 13889 13892 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Merge? |
[skip ci]