Skip to content

Conversation

@PallHaraldsson
Copy link
Contributor

[skip ci]

@PallHaraldsson
Copy link
Contributor Author

In the docs, I couldn't press the edit, to well edit, and the search in the codebase wasn't helpful, then I remembered moved to stdlib. Maybe something can be done about that, for the link and/or doc better.

I found Jutho's package in discourse thread. I'm assuming it works well, at least it's good to know of, and limitations in stdlib should be doced anyway. I don't know if it's the best one (or e.g. as good as Python's sparse), I found other packages thay may not actually be related: https://juliahub.com/ui/Packages/LuxurySparse/4Qz8z/0.6.1

@rayegun
Copy link
Member

rayegun commented Jun 23, 2022

https://sparsearrays.juliasparse.org/dev/#Noteworthy-external-packages Should put it here. But that's a great call out I can't believe I missed SparseArrayKit. LuxurySparse might be a good inclusion, but I'm not sure how impactful it is outside of the Yao ecosystem.

@rayegun
Copy link
Member

rayegun commented Jun 23, 2022

Fantastic! While I'm not sure what is unique about the LuxurySparse package the other two (ExtendableSparse and SparseArrayKit) should at least have a little description. After that we're good to merge!

@PallHaraldsson
Copy link
Contributor Author

LuxurySparse has some additional types so I added it too, and one more that seemed helpful.

I would argue for merging the original commit too, as it clarifies limitation, or at least that part if you do not want to link to a package there. You could however add to that, "see package below" (maybe with a link to that section).

PallHaraldsson and others added 3 commits June 23, 2022 21:53
Co-authored-by: Will Kimmerer <[email protected]>
Co-authored-by: Will Kimmerer <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #160 (14fb225) into main (f8bff3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   34.25%   34.24%   -0.02%     
==========================================
  Files          25       25              
  Lines       21127    21127              
==========================================
- Hits         7238     7235       -3     
- Misses      13889    13892       +3     
Impacted Files Coverage Δ
src/linalg.jl 84.41% <0.00%> (-0.18%) ⬇️
src/sparsematrix.jl 95.28% <0.00%> (-0.05%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ViralBShah
Copy link
Member

Merge?

@rayegun rayegun merged commit 16b28ce into JuliaSparse:main Jun 24, 2022
@PallHaraldsson PallHaraldsson deleted the patch-1 branch June 24, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants