move USE_GPL_LIBS check to the solver files #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include all the solvers tests in testgroups
rayegun
approved these changes
Jun 22, 2022
Member
rayegun
left a comment
rayegun
left a comment
There was a problem hiding this comment.
LGTM, I had some troubles with missing imports here and there, but if no tests fail on that this is good.
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 34.20% 34.24% +0.03%
==========================================
Files 25 25
Lines 21121 21121
==========================================
+ Hits 7224 7232 +8
+ Misses 13897 13889 -8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include all the solvers tests in testgroups
move basetests.jl into issues.jl