Skip to content
This repository was archived by the owner on May 6, 2021. It is now read-only.

Conversation

@Sid-Bhatia-0
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #168 (be0fcdc) into master (df518b6) will decrease coverage by 3.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     actions/toolkit#168      +/-   ##
==========================================
- Coverage   43.58%   39.62%   -3.97%     
==========================================
  Files          38       40       +2     
  Lines         803      906     +103     
==========================================
+ Hits          350      359       +9     
- Misses        453      547      +94     
Impacted Files Coverage Δ
src/components/policies/static_policy.jl 0.00% <0.00%> (ø)
src/components/trajectories/trajectory.jl 71.66% <0.00%> (-10.69%) ⬇️
...rc/components/trajectories/trajectory_extension.jl 0.00% <0.00%> (ø)
src/core/hooks.jl 9.72% <0.00%> (-1.00%) ⬇️
src/core/stop_conditions.jl 29.41% <0.00%> (-7.63%) ⬇️
src/utils/circular_array_buffer.jl 88.88% <ø> (+2.77%) ⬆️
.../components/approximators/abstract_approximator.jl 0.00% <0.00%> (-50.00%) ⬇️
src/components/agents/abstract_agent.jl 25.00% <0.00%> (-36.54%) ⬇️
src/components/trajectories/abstract_trajectory.jl 75.00% <0.00%> (-10.72%) ⬇️
...rc/components/explorers/epsilon_greedy_explorer.jl 46.75% <0.00%> (-5.43%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add77c8...be0fcdc. Read the comment docs.

@findmyway findmyway merged commit 85aed1b into JuliaReinforcementLearning:master Nov 23, 2020
@Sid-Bhatia-0
Copy link
Member Author

@findmyway What about the failed checks in the Julia nightly version?

@findmyway
Copy link
Member

TBH, I don't know...

Watching this issue: actions/runner#2347

@Sid-Bhatia-0
Copy link
Member Author

What if we remove the test on Julia-nightly for now, and add an issue to track it? Otherwise, the unpleasant ❌ symbol would show up every time even when the package works correctly on the latest Julia 1.x.

All the PRs showing an overall ❌ isn't providing any useful information about CI and one will have to go inside every time and look at individual checks to get the relevant information, that is, whether this package works on latest Julia 1.x or not.

We can always add the nightly check later as and when needed.

@findmyway
Copy link
Member

Agree.

@Sid-Bhatia-0 Sid-Bhatia-0 deleted the github_actions_ci branch November 25, 2020 05:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants