-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Description
The current type for CircularArrayBuffer only allows the backing array to be an Array. Can this be relaxed to allow CuArrays (or any AbstractArray)? AFAICT scalar indexing is not introduced by the package code (meaning scalar indexing should only trigger if a user is scalar indexing in the first place).
You might also consider adding an Adapt.jl rule:
Adapt.adapt_structure(to, x::CircularArrayBuffer) =
CircularArrayBuffer(adapt(to, x.buffer), x.first, x.nframes, x.step_size)Metadata
Metadata
Assignees
Labels
No labels