Skip to content

Do not swallow exceptions in %julia magic #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not swallow exceptions in %julia magic #265

wants to merge 1 commit into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Apr 3, 2019 •
edited
Loading

Errors should never pass silently.
Unless explicitly silenced.

(see #266 for full context)

@tkf tkf mentioned this pull request Apr 3, 2019
Open
@coveralls
Copy link

coveralls commented Apr 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 651

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.519%
Totals Coverage Status
Change from base Build 647: -0.1%
Covered Lines: 932
Relevant Lines: 1218
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 651

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.519%
Totals Coverage Status
Change from base Build 647: -0.1%
Covered Lines: 932
Relevant Lines: 1218
💛 - Coveralls

@tkf
Copy link
Member Author

tkf commented Apr 8, 2019

#262 did it

@tkf tkf closed this Apr 8, 2019
@tkf tkf deleted the raise branch April 8, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @coveralls