Skip to content

Fix pyraise #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

Fix pyraise #675

merged 1 commit into from
Apr 4, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Apr 4, 2019

tkf
tkf commented Apr 4, 2019
View reviewed changes
src/exception.jl
setfield!(e.traceback, :o, C_NULL)
setfield!(e.T, :o, PyPtr_NULL)
setfield!(e.val, :o, PyPtr_NULL)
setfield!(e.traceback, :o, PyPtr_NULL)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are all PyObject so .o has to be of type PyPtr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I thought setfield! automatically called convert (JuliaLang/julia#16195)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that's not the case JuliaLang/julia#16195 (comment)

@tkf tkf mentioned this pull request Apr 4, 2019
Merged
@stevengj
Copy link
Member

stevengj commented Apr 4, 2019 •
edited
Loading

The AppVeyor failure

Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
Exception: EXCEPTION_ACCESS_VIOLATION at 0xffdefdd -- unknown function (ip: 0FFDEFDD)
in expression starting at C:\projects\pycall-jl-nu3aa\test\runtests.jl:29
unknown function (ip: 0FFDEFDC)
PyObject_GetAttr at C:\windows\SYSTEM32\python27.dll (unknown line)
PyObject_CallFunctionObjArgs at C:\windows\SYSTEM32\python27.dll (unknown line)
PyType_Modified at C:\windows\SYSTEM32\python27.dll (unknown line)
PyCFunction_Call at C:\windows\SYSTEM32\python27.dll (unknown line)
PyObject_Call at C:\windows\SYSTEM32\python27.dll (unknown line)
PyObject_CallFunctionObjArgs at C:\windows\SYSTEM32\python27.dll (unknown line)
PyObject_IsInstance at C:\windows\SYSTEM32\python27.dll (unknown line)
pyint_query at C:\projects\pycall-jl-nu3aa\src\PyCall.jl:173
pytype_query at C:\projects\pycall-jl-nu3aa\src\conversions.jl:770
pytype_query at C:\projects\pycall-jl-nu3aa\src\conversions.jl:803
convert at C:\projects\pycall-jl-nu3aa\src\conversions.jl:828
roundtrip at C:\projects\pycall-jl-nu3aa\test\runtests.jl:13 [inlined]
roundtrip at C:\projects\pycall-jl-nu3aa\test\runtests.jl:14 [inlined]
roundtripeq at C:\projects\pycall-jl-nu3aa\test\runtests.jl:16

is surprising, but I don't see how it could be related. Maybe a problem on nightly?

@stevengj stevengj merged commit 9149170 into JuliaPy:master Apr 4, 2019
@tkf tkf mentioned this pull request Apr 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @stevengj