installer silently fails?

[stevengj]

I'm trying a 64-bit Windows 8 machine (technically, running on a Mac under VMware fusion) with Julia 0.4.0-rc4, and the miniconda installer seems to silently do nothing:

That is, it runs installer.exe and seems to succeed (no error is printed), but nothing seems to be installed (no conda command or anything else in deps/usr except for installer.exe itself).

Anything I should be trying?

[Luthaf]

Can you try to run it directly ?

using Conda
installer = joinpath(Conda.SCRIPTDIR, "installer.exe")
PREFIX = Conda.PREFIX
run(`$installer /S  /AddToPath=0 /RegisterPython=0 /D=$PREFIX`)

[stevengj]

joinpath(Conda.SCRIPTDIR, "installer.exe") doesn't exist, but joinpath(dirname(Conda.SCRIPTDIR), "installer.exe") exists. However, run($installer /S /AddToPath=0 /RegisterPython=0 /D=$PREFIX) produces no output — it succeeds in the sense that success($installer /S /AddToPath=0 /RegisterPython=0 /D=$PREFIX) is true, but it appears to do nothing.

[stevengj]

Running installer.exe (with the same arguments as above) at the command line also seems to do nothing.

[stevengj]

Trying to run installer.exe with no arguments brings up the GUI installer, but when I try to install into PREFIX it complains that the directory already exists.

[stevengj]

If I move installer.exe to the deps directory and delete usr, the silent install still fails, but I was able to succeed with the GUI install.

[stevengj]

Does it matter that my home directory has two spaces in it? Just wondering if this is one of those "script gets confused by whitespace" problems.

[Luthaf]

It might be that kind of issue. Other than that, I have no idea ...

[stevengj]

Nope, it still fails silently copying installer.exe to a path not containing spaces.

[mlubin]

Another report of this happening on Windows 10. The user has a space in their user name/home directory.

CC @juan-pablo-vielma

[Luthaf]

As I do not have a windows machine with me, I can not investigate this. If someone can try to dig this bug, I can try to fix it after.

[dhoegh]

I have investigated the issue. The core issue is that the quoting of the backticks is wrong and interfere with the argument passing on line: https://github.com/Luthaf/Conda.jl/blob/9dbdbca7e8338a67576bb3e92191b0000cd0d68e/src/Conda.jl#L120
The cmd on that line return a quote around the /D=path and not only the path, as:

julia> `$installer /S  /AddToPath=0 /RegisterPython=0 /D=$PREFIX`
path/Installer.exe /S  /AddToPath=0 /RegisterPython=0 '/D=path'`

This makes the installer fail silently. This issue has also occurred in JuliaLang/IJulia.jl#211 (comment). @ihnorton's workaround from https://gist.github.com/ihnorton/82dc5b41a537de710ab2 segfualt under 0.4. I cannot figure out why it segfault and it is not a good long term solution.

The easiest way to reproduce this failure under windows is:

 ENV["HOME"]="C:\\Users\\test\\My\ test\ home\\"
Pkg.add("Conda")
 using Conda
 Conda.list()

[Luthaf]

Thank you for taking the time to do this!

The cmd on that line return a quote around the /D=path and not only the path

Ok, so that is an issue with Julia quoting. Could quoting the path by ourselve fix this ? Like this:

`$installer /S  /AddToPath=0 /RegisterPython=0 /D="$PREFIX"`

@ihnorton's workaround from https://gist.github.com/ihnorton/82dc5b41a537de710ab2 segfualt under 0.4. I cannot figure out why it segfault and it is not a good long term solution.

This is messing directly with Win32 API, which I would prefer not have to do.

[dhoegh]

It will still quotes wrong.

julia> `installer /S  /AddToPath=0 /RegisterPython=0 /D="test space"`
`installer /S  /AddToPath=0 /RegisterPython=0 '/D=test space'`

Anyway the path should not be quoted at all according to my experience, supported by conda/conda#1068 (comment).