New template using Xranklin #6
Conversation
…d warnings. The issue related to variables arbitrarily set to 'nothing' persists. You must run 'serve' twice for it to work. Is this a bug in Franklin?
Adding new commits from main repo
update from juliaparallel
|
@jpsamaroo, @sloede, @giordano Hi!, if you agree we can try to merge this new version :) (ps: if you think it's necessary please add the manifest) |
There was a problem hiding this comment.
A bunch of .DS_Store files have been added. They should be removed and added to .gitignore.
And yes, I still think the environment (Project + Manifest) actually used to build the website has to be added to the repository. If I want to build the website on my computer for local testing, I have no idea what to do, I can't possibly know what environment will be used in production.
Done. Thanks.
Is this how they are supposed to be added? or is there a cleaner way? In last deploy we apparently do not need them: |
For example, yes.
Well, I presume the CI job creates an environment on-the-fly. That's completely unreproducible though, which I'm not exactly happy about. The CI job should use the environment added to the repository, so that I (or anyone else) can also build the website locally in a reproducible way. |
|
Good, I added Manifest.toml and Project.toml, and I removed Manifest.toml from the gitignore. I add the following information in case it is needed: to run the local version of project I am using a fresh Julia installation, Version 1.7.3 (2022-05-06). Then I installed Xranklin ( |
|
In case you think it is convenient to modify the deploy ( |
Merge pull request #15 from emmanuellujan/new-template
3 participants
New JuliaParallel template, adapted to Xranklin with the help of @tlienart :)
I just have a doubt about whether Deploy.yml will work here too, but I think it will (I removed the base url prefix).