Test suite: Add more test coverage for warn_if_unexpected_params() (only on Julia versions prior to 1.6)
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
8f02cca to
938306b
Compare
DilumAluthge
force-pushed
the
dpa/warn_if_unexpected_params-2
branch
2 times, most recently
from
11768aa to
2638f9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dpa/ntasks #45 +/- ##
==============================================
+ Coverage 93.13% 94.11% +0.98%
==============================================
Files 2 2
Lines 102 102
==============================================
+ Hits 95 96 +1
+ Misses 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
changed the title
warn_if_unexpected_params()warn_if_unexpected_params() (only on Julia versions prior to 1.6)
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
ae30922 to
74bf0e8
Compare
DilumAluthge
force-pushed
the
dpa/warn_if_unexpected_params-2
branch
2 times, most recently
from
540e0a1 to
344d45c
Compare
|
Coverage after this PR: 94% |
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
74bf0e8 to
03df383
Compare
DilumAluthge
force-pushed
the
dpa/warn_if_unexpected_params-2
branch
from
344d45c to
19e1470
Compare
DilumAluthge
force-pushed
the
dpa/ntasks
branch
from
03df383 to
7692b64
Compare
…(only on Julia versions prior to 1.6)
DilumAluthge
force-pushed
the
dpa/warn_if_unexpected_params-2
branch
from
19e1470 to
1feb0b2
Compare
|
@kleinhenz This PR is now ready for review. |
kleinhenz
approved these changes
Apr 29, 2025
|
Oops. I wanted to merge this into master, not into I'll cherry pick and make an new PR. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
SLURM_NTASKSandSLURM_JOB_IDfunctionality out into separate utility functions, and add some more unit tests to increase code coverage #44