Catch exception thrown from sleep() in the Distributed watcher #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 87.83% 87.99% +0.16%
==========================================
Files 11 11
Lines 2063 2066 +3
==========================================
+ Hits 1812 1818 +6
+ Misses 251 248 -3 ☔ View full report in Codecov by Sentry. |
|
What kind of errors did you get from sleep, and under what conditions? |
|
For me it happens sporadically when exiting the REPL with Ctrl + D: Unhandled Task ERROR: EOFError: read end of file
Stacktrace:
[1] wait
@ ./asyncevent.jl:162 [inlined]
[2] sleep
@ ./asyncevent.jl:272 [inlined]
[3] (::DistributedNext.var"#287#288")()
@ DistributedNext ~/git/Distributed.jl/src/DistributedNext.jl:145There was a related Julia issue for this somewhere... I haven't been able to find a consistent reproducer. |
JamesWrigley
force-pushed
the
close-watcher
branch
from
3bb5e66 to
4e28902
Compare
Otherwise the exception would be printed when the process exits.
The watcher entry was accidentally added under the v1 changelog.
JamesWrigley
force-pushed
the
close-watcher
branch
from
4e28902 to
91077f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the changelog in 3bb5e66.