-
-
Notifications
You must be signed in to change notification settings - Fork 73
Deprecate (but do not remove) the Slurm functionality in this package (and point users to SlurmClusterManager.jl instead) #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c46a7a1 to
d558a54
Compare
577ee74 to
d558a54
Compare
d558a54 to
c82f5fe
Compare
c82f5fe to
6b1af89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 37.62% 37.85% +0.22%
==========================================
Files 7 7
Lines 388 391 +3
==========================================
+ Hits 146 148 +2
- Misses 242 243 +1 ☔ View full report in Codecov by Sentry. |
|
@kleinhenz What are your thoughts on moving forward with this? |
6b1af89 to
cbeb2dc
Compare
… (and point users to SlurmClusterManager.jl instead)
cbeb2dc to
b35ad48
Compare
|
Bump @kleinhenz - Shall we move forward with merging this PR and making a new release of ClusterManagers.jl? |
|
That makes sense to me |
Depends on:
We'll first release a non-breaking release of ClusterManagers.jl with the deprecation warning.
Then, we'll follow-up with a breaking release of ClusterManagers.jl that fully removes the Slurm functionality from this package.
The README (of this package) will point users to the SlurmClusterManager.jl package instead.