Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

Conversation

bmharsha
Copy link

WinRPM is encountering download errors because cached links are failing on some Windows servers, removing the caching resolves this issue on those servers. So, this PR provides non-cached links as alternative whenever cached links fail.

Cached links are failing on some Windows virtual machines, especially the ones that are located on Amazon and Azure, removing the caching resolves this issue on those servers. So, this PR provides non-cached links as alternative whenever cached links fail.
@tkelman
Copy link
Contributor

tkelman commented Jul 13, 2017

What does a log look like when both links work?

@bmharsha
Copy link
Author

What does a log look like when both links work?

Here is a log when both links work
https://gist.github.com/bmharsha/c79def27220871a7e85243103daf83ae#file-winrpm_both_working-md

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2017

and packages install correctly?

@bmharsha
Copy link
Author

and packages install correctly?

Yes, WinRPM installs correctly and I tried a few examples from WinRPM readme, here is a log of that.

https://gist.github.com/bmharsha/c79def27220871a7e85243103daf83ae#file-winrpm_usage-md

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2017

All those multiple candidate warnings are a problem, so this isn't great as is. Will need to find a way to avoid all those.

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2017

One thing we could try is leave sources.list alone, but if the download gets to its retry limit then try again with the cache prefix removed as part of the download code.

@musm
Copy link
Contributor

musm commented Jul 19, 2017

I am pretty sure the download function is fundamentally bugged.

@bmharsha Is your system 32-bit ?

@musm
Copy link
Contributor

musm commented Jul 19, 2017

On my fork I think I have at least fixed the download issue I get with HDF5 for 32-bit windows (at least on 0.5 and 0.6). You can try my fork and see if it fixes things for you https://github.com/musm/WinRPM.jl

On 0.7 I get a strange stack overflow error with a circular reference https://ci.appveyor.com/project/musm/winrpm-jl/build/job/nuoo2f5do90wm8dh

@bmharsha
Copy link
Author

@bmharsha Is your system 32-bit ?

No, it's a 64 bit system.

On my fork I think I have at least fixed the download issue I get with HDF5 for 32-bit windows (at least on 0.5 and 0.6). You can try my fork and see if it fixes things for you https://github.com/musm/WinRPM.jl

Sure, I'll try this and report back, thanks.

@musm
Copy link
Contributor

musm commented Jul 19, 2017

Thanks. Another option is just to get rid of the download function and use the one in Base.

@bmharsha
Copy link
Author

@musm I tried your fork on "Windows Server 2012 R2 datacenter" (64 bit), I'm still seeing download errors, here is a full log

https://gist.github.com/bmharsha/c79def27220871a7e85243103daf83ae#file-musm_winrpm-md

@musm
Copy link
Contributor

musm commented Jul 19, 2017

@bmharsha Sorry about that. Do you mind trying again? I made some updates on master.
https://github.com/musm/WinRPM.jl

@bmharsha
Copy link
Author

Do you mind trying again?

I tried again, download errors are now gone, we just have following warning

WARNING: skipping repodata/repomd.xml, not in cache -- call WinRPM.update() to download

Here is the full log
https://gist.github.com/bmharsha/c79def27220871a7e85243103daf83ae#file-winrpm_musm_fix-md

@musm
Copy link
Contributor

musm commented Jul 20, 2017

Ok so it looks like that works fine? Not sure why the links are cached anyways, as I too have run in into this problem in the past.

It looks like the WinRPM download function is flakey when it comes to url redirects.

@bmharsha
Copy link
Author

Ok so it looks like that works fine?

Yes, it works. Thank you @musm , are you planning to send a PR from your fork, shall I close this PR?

@musm
Copy link
Contributor

musm commented Jul 25, 2017

That suggests we should use powershell for download since it seems to properly handle redirects

@musm
Copy link
Contributor

musm commented Jul 30, 2017

#118 same issue again...

@musm
Copy link
Contributor

musm commented Jul 30, 2017

I think we should move quick to fix this (the appveyor builds in HDF5 are super flaky too)
@tkelman My preference is to add powershell to the download function in Base then add it to Compat and then use that here. Is that ok or do you want to do something else to fix this issue?

@musm
Copy link
Contributor

musm commented Jul 30, 2017

OTOH it would be a lot quicker to add the change here first (1 PR vs 3 PRs)

@musm
Copy link
Contributor

musm commented Jul 31, 2017

@bmharsha opened here #122

@bmharsha
Copy link
Author

bmharsha commented Aug 1, 2017

Closing this PR in favor of #122 , thanks @musm

@bmharsha bmharsha closed this Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants