[Runner] Set also minimum SDK version when targeting macOS #284
Conversation
giordano
force-pushed
the
mg/macos-ld-sdk-version
branch
from
f963fa6 to
4f27972
Compare
src/Runner.jl
Outdated
| function min_macos_version_flags(p::AbstractPlatform) | ||
| ver = macos_version(p) | ||
| # Ask compilers to compile for a minimum macOS version, targeting that SDK. | ||
| return ("-mmacosx-version-min=$(ver)", "-Wl,-sdk_version,$(ver)") |
There was a problem hiding this comment.
@staticfloat what do you think about using here
("-mmacosx-version-min=\${MACOSX_DEPLOYMENT_TARGET}", "-Wl,-sdk_version,\${MACOSX_DEPLOYMENT_TARGET}")? The idea is that in the cases where we use a different SDK we can still set the same value by overriding the environment variable MACOSX_DEPLOYMENT_TARGET, which is otherwise set to the default macOS SDK version:
BinaryBuilderBase.jl/src/Runner.jl
Line 1182 in 43ba740
There was a problem hiding this comment.
Looking at the value of MACOSX_DEPLOYMENT_TARGET is also what cctools linker should in principle do (even though I didn't manage to make it work): https://github.com/tpoechtrager/cctools-port/blob/634a084377ee2e2932c66459b0396edf76da2e9f/cctools/ld64/src/ld/Options.cpp#L5378-L5394.
Therefore I'm going with this option because it's more consistent (the environment variable MACOSX_DEPLOYMENT_TARGET is used by build systems, like CMake) and offers users an escape hatch when they use a different SDK.
giordano
force-pushed
the
mg/macos-ld-sdk-version
branch
from
0f0c89d to
0d03d9b
Compare
giordano
force-pushed
the
mg/macos-ld-sdk-version
branch
from
0d03d9b to
cefd386
Compare
1 participant
Needs tests