Skip to content

Fix bigfloat conversion for Julia v1.12 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix bigfloat conversion for Julia v1.12 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Quadmath.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,14 @@ Float128(x::Irrational{T}) where {T} = Float128(BigFloat(x))

import Base.MPFR

@static if VERSION >= v"1.12.0-DEV.1343"
const _big_setindex! = Base.setindex!
const _big_getindex = Base.getindex
else
const _big_setindex! = unsafe_store!
const _big_getindex = unsafe_load
end

function BigFloat(x::Float128; precision=precision(BigFloat))
if !isfinite(x) || iszero(x)
@static if VERSION < v"1.1"
Expand All @@ -490,13 +498,13 @@ function BigFloat(x::Float128; precision=precision(BigFloat))
i = cld(precision, sizeof(MPFR.Limb)*8)
while u != 0
w = (u >> (128-sizeof(MPFR.Limb)*8)) % MPFR.Limb
unsafe_store!(b.d, w, i)
_big_setindex!(b.d, w, i)
i -= 1
u <<= sizeof(MPFR.Limb)*8
end
# set remaining bits to zero
while i > 0
unsafe_store!(b.d, zero(MPFR.Limb), i)
_big_setindex!(b.d, zero(MPFR.Limb), i)
i -= 1
end

Expand Down Expand Up @@ -547,7 +555,7 @@ function Float128(x::BigFloat)
j = 113
while i > 0
j -= sizeof(MPFR.Limb)*8
u |= (unsafe_load(y.d, i) % UInt128) << j
u |= (_big_getindex(y.d, i) % UInt128) << j
i -= 1
end
u &= significand_mask(Float128)
Expand Down
Loading