-
Notifications
You must be signed in to change notification settings - Fork 29
Accept arbitrary arrays also for var and std. #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Accept arbitrary arrays also for var and std. #98
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 1 1
Lines 154 154
=======================================
Hits 145 145
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/NaNMath.jl
Outdated
|
|
||
| """ | ||
| NaNMath.var(A) | ||
| `NaNMath.var(A)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `NaNMath.var(A)` | |
| NaNMath.var(A::AbstractArray{<:AbstractFloat}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had trouble getting the normal four space indentation to mark it correctly but now I see that it's the 1.12 non-public warning notice that interferes.
|
I agree that there are all sorts of improvements that could be made to this package but my ambitions don't go further than what's in this PR. Feel free to take it over and make a better PR if you want. |
Most functions were extended from
VectortoAbstractArrayin #20, but notvarandstd. I don't see a need for this inconsistency, so this PR loosens their type constraints. It also revises their docstrings to make a bit more sense.