Skip to content

Conversation

@GunnarFarneback
Copy link

Most functions were extended from Vector to AbstractArray in #20, but not var and std. I don't see a need for this inconsistency, so this PR loosens their type constraints. It also revises their docstrings to make a bit more sense.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.15%. Comparing base (b1040f3) to head (b0fbe83).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files           1        1           
  Lines         154      154           
=======================================
  Hits          145      145           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/NaNMath.jl Outdated

"""
NaNMath.var(A)
`NaNMath.var(A)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`NaNMath.var(A)`
NaNMath.var(A::AbstractArray{<:AbstractFloat})

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble getting the normal four space indentation to mark it correctly but now I see that it's the 1.12 non-public warning notice that interferes.

@GunnarFarneback
Copy link
Author

GunnarFarneback commented Nov 15, 2025

I agree that there are all sorts of improvements that could be made to this package but my ambitions don't go further than what's in this PR. Feel free to take it over and make a better PR if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants