Use sampler-based Random API #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 87.84% 87.89% +0.05%
==========================================
Files 6 6
Lines 469 471 +2
==========================================
+ Hits 412 414 +2
Misses 57 57
Continue to review full report at Codecov.
|
Member
|
How bad is the regression for generation? |
This avoids the performance problem with `ReinterpretArray`.
Collaborator
Author
|
I added a method using |
timholy
approved these changes
Aug 7, 2020
Collaborator
Author
|
Thank you for your prompt review. |
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 27, 2024
This prevents `rand` from returning a `ReinterpretArray` to avoid the performance problem with `ReinterpretArray` . This also supports specifying the RNG option.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
This prevents `rand` from returning a `ReinterpretArray` to avoid the performance problem with `ReinterpretArray` . This also supports specifying the RNG option.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This prevents `rand` from returning a `ReinterpretArray` to avoid the performance problem with `ReinterpretArray` . This also supports specifying the RNG option.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This prevents `rand` from returning a `ReinterpretArray` to avoid the performance problem with `ReinterpretArray` . This also supports specifying the RNG option.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This prevents `rand` from returning a `ReinterpretArray` to avoid the performance problem with `ReinterpretArray` . This also supports specifying the RNG option.
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 28, 2024
This also backports the changes in PR JuliaMath#270, JuliaMath#278
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 28, 2024
This also backports the changes in PR JuliaMath#270, JuliaMath#278.
kimikage
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196, Fixes #125
This avoids the performance problem with
ReinterpretArray.On the other hand, the time for generating the random number array with the default RNG is significantly increased.I chose a minimalistic and straightforward implementation for now.