Skip to content

Performance fix: avoid unnecessary convert on setindex!、copy when type is same. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Performance fix: avoid unnecessary convert on setindex!、copy when type is same. #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9276173
Add `convert(::Type{T}, x::T) where {T<:FD} = x`
NHDaly Nov 7, 2018
54d2d5a
Remove "copy constructor" after correct `convert` fix
NHDaly Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/FixedPointDecimals.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ struct FixedDecimal{T <: Integer, f} <: Real
_throw_storage_error(f, T, n)
end
end

# Copy constructor -- prevents unneeded work to convert between the same types
FixedDecimal{T,f}(x::FixedDecimal{T,f}) where {T<:Integer,f} = new{T,f}(x.i)
end

@noinline function _throw_storage_error(f, T, n)
Expand Down Expand Up @@ -274,6 +271,8 @@ function round(::Type{FD{T, f}}, x::Rational, ::RoundingMode{:Nearest}=RoundNear
end

# conversions and promotions
convert(::Type{FD{T, f}}, x::FD{T, f}) where {T, f} = x # Converting an FD to itself is a no-op

function convert(::Type{FD{T, f}}, x::Integer) where {T, f}
reinterpret(FD{T, f}, T(widemul(x, coefficient(FD{T, f}))))
end
Expand Down