Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jun 30, 2023

This moves the Toeplitz functions from JuliaArrays/FillArrays.jl#256, so that eigen/eigvals for tridiagonal matrices with Fill bands become O(n)/O(n^2) after loading this package. This is type-piracy, but it was suggested that this be added to this package.

julia> using FillArrays, LinearAlgebra, ToeplitzMatrices, BenchmarkTools

julia> S = SymTridiagonal(Fill(4.0, 5000), Fill(3.0, 4999));

julia> @btime eigvals($S);
  153.141 μs (2 allocations: 39.11 KiB)

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 95.50% and project coverage change: +0.03 🎉

Comparison is base (49bde1d) 94.98% compared to head (0c805db) 95.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   94.98%   95.02%   +0.03%     
==========================================
  Files           7        8       +1     
  Lines         798      884      +86     
==========================================
+ Hits          758      840      +82     
- Misses         40       44       +4     
Impacted Files Coverage Δ
src/ToeplitzMatrices.jl 87.50% <81.81%> (-4.81%) ⬇️
src/eigen.jl 96.92% <96.92%> (ø)
src/hankel.jl 96.20% <100.00%> (+0.04%) ⬆️
src/special.jl 99.33% <100.00%> (+0.03%) ⬆️
src/toeplitz.jl 97.56% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 274044a into JuliaLinearAlgebra:master Jul 11, 2023
@jishnub jishnub deleted the eigen branch July 11, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant