Skip to content

Adjustment to AdjointQ introduction in LinearAlgebra #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Adjustment to AdjointQ introduction in LinearAlgebra #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83c7aa0
Adjustment to `AdjointQ` introduction in LinearAlgebra
dkarrasch Aug 3, 2022
d59e7cc
bump patch version, specify version
dkarrasch Aug 3, 2022
bf6c753
adjust version number
dkarrasch Aug 22, 2022
68dd093
Update svd.jl
dkarrasch Sep 24, 2022
34e1f79
Fix typo
dkarrasch Sep 24, 2022
1553f74
Merge branch 'master' into dk/adjointq
dkarrasch Nov 5, 2022
7c37d19
fix Quaternions.jl version for testing
dkarrasch Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "GenericLinearAlgebra"
uuid = "14197337-ba66-59df-a3e3-ca00e7dcff7a"
version = "0.3.4"
version = "0.3.5"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand All @@ -9,6 +9,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
libblastrampoline_jll = "8e850b90-86db-534c-a0d3-1478176c7d93"

[compat]
Quaternions = "=0.6.0"
julia = "1.6"

[extras]
Expand Down
7 changes: 4 additions & 3 deletions src/svd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ using LinearAlgebra

import LinearAlgebra: mul!, rmul!

AdjointQtype = isdefined(LinearAlgebra, :AdjointQ) ? LinearAlgebra.AdjointQ : Adjoint

lmul!(G::LinearAlgebra.Givens, ::Nothing) = nothing
rmul!(::Nothing, G::LinearAlgebra.Givens) = nothing

Expand Down Expand Up @@ -347,7 +349,7 @@ function lmul!(Q::LinearAlgebra.HessenbergQ, B::AbstractVecOrMat)
return B
end

function lmul!(adjQ::Adjoint{<:Any,<:LinearAlgebra.HessenbergQ}, B::AbstractVecOrMat)
function lmul!(adjQ::AdjointQtype{<:Any,<:LinearAlgebra.HessenbergQ}, B::AbstractVecOrMat)

Q = parent(adjQ)
m, n = size(B, 1), size(B, 2)
Expand Down Expand Up @@ -398,8 +400,7 @@ function rmul!(A::AbstractMatrix, Q::LinearAlgebra.HessenbergQ)
return A
end

function rmul!(A::AbstractMatrix, adjQ::Adjoint{<:Any,<:LinearAlgebra.HessenbergQ})

function rmul!(A::AbstractMatrix, adjQ::AdjointQtype{<:Any,<:LinearAlgebra.HessenbergQ})
m, n = size(A)
Q = parent(adjQ)

Expand Down