Use -force_load, rather than -all_load, on ld64 (macOS) #60160
Merged
+27
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using ld64's
-all_loadas the mac equivalent to--whole-archive, but-force_loaddoes something closer to what we want. From the ld64 man page:When we link
libjulia-internal.dylibandlibjulia-codegen.dylibwith-all_load, we pull in more of the static LLVM support libraries than we need.Before:
After: