Replace some uses of Array by Vector or Matrix
#60154
Open
+165
−165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards issue #56922 by @LilithHafner. Turns out I didn't find many uses of
Array{T, 1}orArray{T, 2}indocorbasethat were "clearly" in need of being updated toVectororMatrix.There are a bunch that can't be changed because they occur before
VectororMatrixare even defined.There are a couple borderline cases, and I may have overlooked some, but most I looked at felt like "I could change it to Vector or Matrix but I think there is a didactical point in using
Arrayhere. E.g. in the definition ofstruct BitVector <: AbstractArray{Bool, 1}; endI think the context makes it desirable to leave it at that instead of changing it toVector-- but I admit this is subjective.There was more in
test, though that's perhaps less important.All in all I think we could close #56922