extend Method.dispatch_status optimization to ml_matches_visitor also #58335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
performance
|
Any performance measurements? |
|
Not really, the cases where this triggers are likely fairly rare, but it simplifies the code |
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2025
58 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 12, 2025
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
…JuliaLang#58335) This extends the use of the optimization in JuliaLang#58291 to also apply to some uses of ml_matches also.
KristofferC
pushed a commit
to DilumAluthgeBot/julia
that referenced
this pull request
May 12, 2025
…JuliaLang#58335) This extends the use of the optimization in JuliaLang#58291 to also apply to some uses of ml_matches also. (cherry picked from commit d1ec7d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the use of the optimization in #58291 to also apply to some uses of ml_matches also.