Remove some unnecessary specialization #58059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods compile to the same machine code regardless of input type, and in the case of firstindex(::Tuple), also infers the same types.
This avoids creating a ton of new methods for in(x, ::NTuple), which generically is recursively implemented, in order to support inference for heterogenous tuples.
Member
Author
|
CI failure is unrelated (OOM on 32-bit Linux). |
Member
Author
|
Closing as probably outdated, and also, @nsajko has done much more work on this so he should continue the effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of a small hunt I went on to find redundant methodinstances.
The results are disappointing - compared to master (commit 4480f42), it removes ~830 methodinstances (about 1% of those in the sysimg), and saves only 2.6MB in
sys.so. Nonetheless, it may as well get merged.Some more stuff that could be done but I don't know how to
@nospecializeor@nospecializeinferin the bootstrapping processsroa_pass!(ir::Compiler.IRCode, inlining::Union{Nothing, Compiler.InliningState}). Maybe those could be singled out for refactoring.