use @main for juliac executable entry point
#57588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/juliacatmain
branch
3 times, most recently
from
069533d to
4a7e6d6
Compare
fingolfin
approved these changes
May 7, 2025
|
Thanks. I have an idea to improve this. We should detect whether you've written your own ccallable |
JeffBezanson
force-pushed
the
jb/juliacatmain
branch
2 times, most recently
from
ac988cb to
2633905
Compare
add support for command line arguments
JeffBezanson
force-pushed
the
jb/juliacatmain
branch
from
2633905 to
12c89b9
Compare
58 tasks
topolarity
pushed a commit
that referenced
this pull request
Jun 27, 2025
Use at-main mechanism in juliac executables. Also add support for command line arguments.
I changed `Core.ARGS` from a `Vector{Any}` to a `Vector{String}`. I
don't know why we didn't do that years ago. Surely this is ok?
(cherry picked from commit d9c8c42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
juliac clearly should use the at-main mechanism for executables. That also allows us to call julia_init from C main instead of using
__attribute__((constructor)). I also added support for passing in the command line arguments (kind of useful!)I changed
Core.ARGSfrom aVector{Any}to aVector{String}. I don't know why we didn't do that years ago. Surely this is ok?The biggest problem is looking up juliamainfrom C main. For now I put in a hack to keep the binding around, but it's not very satisfying. Maybe we should insert accallablewith some known name likejuliac_exe_main? Any other ideas on how to handle this? Edit: done.