Skip to content

also redirect JL_STDERR etc. when redirecting to devnull #55958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2025
Merged

also redirect JL_STDERR etc. when redirecting to devnull #55958

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9665f77
also redirect JL_STDERR etc. when redirecting to devnull
IanButterworth Oct 1, 2024
8679995
Update stream.jl
vtjnash Oct 3, 2025
49bc66b
Update stream.jl
vtjnash Oct 3, 2025
c5710cf
Update stream.jl
vtjnash Oct 3, 2025
20846ef
Merge branch 'master' into ib/redirect_stdio_devnull_c
DilumAluthge Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions base/stream.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,15 @@ function _redirect_io_libc(stream, unix_fd::Int)
-10 - unix_fd, Libc._get_osfhandle(posix_fd))
end
end
dup(posix_fd, RawFD(unix_fd))
GC.@preserve stream dup(posix_fd, RawFD(unix_fd))
nothing
end
function _redirect_io_cglobal(handle::Union{LibuvStream, IOStream, Nothing}, unix_fd::Int)
c_sym = unix_fd == 0 ? cglobal(:jl_uv_stdin, Ptr{Cvoid}) :
unix_fd == 1 ? cglobal(:jl_uv_stdout, Ptr{Cvoid}) :
unix_fd == 2 ? cglobal(:jl_uv_stderr, Ptr{Cvoid}) :
C_NULL
c_sym == C_NULL || unsafe_store!(c_sym, handle === nothing ? Ptr{Cvoid}(unix_fd) : handle.handle)
nothing
end
function _redirect_io_global(io, unix_fd::Int)
Expand All @@ -1256,11 +1264,7 @@ function _redirect_io_global(io, unix_fd::Int)
end
function (f::RedirectStdStream)(handle::Union{LibuvStream, IOStream})
_redirect_io_libc(handle, f.unix_fd)
c_sym = f.unix_fd == 0 ? cglobal(:jl_uv_stdin, Ptr{Cvoid}) :
f.unix_fd == 1 ? cglobal(:jl_uv_stdout, Ptr{Cvoid}) :
f.unix_fd == 2 ? cglobal(:jl_uv_stderr, Ptr{Cvoid}) :
C_NULL
c_sym == C_NULL || unsafe_store!(c_sym, handle.handle)
_redirect_io_cglobal(handle, f.unix_fd)
_redirect_io_global(handle, f.unix_fd)
return handle
end
Expand All @@ -1269,6 +1273,7 @@ function (f::RedirectStdStream)(::DevNull)
handle = open(nulldev, write=f.writable)
_redirect_io_libc(handle, f.unix_fd)
close(handle) # handle has been dup'ed in _redirect_io_libc
_redirect_io_cglobal(nothing, f.unix_fd)
_redirect_io_global(devnull, f.unix_fd)
return devnull
end
Expand Down