Skip to content

Revert "Improve printing of several arguments" #55894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Revert "Improve printing of several arguments" #55894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions base/strings/io.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ end
function print(io::IO, xs...)
lock(io)
try
foreach(Fix1(print, io), xs)
for x in xs
print(io, x)
end
finally
unlock(io)
end
Expand Down Expand Up @@ -136,20 +138,32 @@ function print_to_string(xs...)
if isempty(xs)
return ""
end
siz = sum(_str_sizehint, xs; init = 0)
siz::Int = 0
for x in xs
siz += _str_sizehint(x)
end
# specialized for performance reasons
s = IOBuffer(sizehint=siz)
print(s, xs...)
for x in xs
print(s, x)
end
String(_unsafe_take!(s))
end

function string_with_env(env, xs...)
if isempty(xs)
return ""
end
siz = sum(_str_sizehint, xs; init = 0)
siz::Int = 0
for x in xs
siz += _str_sizehint(x)
end
# specialized for performance reasons
s = IOBuffer(sizehint=siz)
env_io = IOContext(s, env)
print(env_io, xs...)
for x in xs
print(env_io, x)
end
String(_unsafe_take!(s))
end

Expand Down