Skip to content

REPL: use atreplinit to change the active module during precompilation #55805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

REPL: use atreplinit to change the active module during precompilation #55805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a7fe23
use atreplinit to change the active module
IanButterworth Sep 18, 2024
8d4eea1
use an Event instead
IanButterworth Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions stdlib/REPL/src/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,21 @@ function repl_workload()
UP_ARROW = "\e[A"
DOWN_ARROW = "\e[B"

# This is notified as soon as the first prompt appears
repl_init_event = Base.Event()

atreplinit() do repl
# Main is closed so we can't evaluate in it, but atreplinit runs at
# a time that repl.mistate === nothing so REPL.activate fails. So do
# it async and wait for the first prompt to know its ready.
t = @async begin
wait(repl_init_event)
REPL.activate(REPL.Precompile; interactive_utils=false)
end
Base.errormonitor(t)
end

repl_script = """
import REPL
REPL.activate(REPL.Precompile; interactive_utils=false) # Main is closed so we can't evaluate in it
2+2
print("")
printstyled("a", "b")
Expand All @@ -62,7 +74,6 @@ function repl_workload()
[][1]
Base.Iterators.minimum
cd("complete_path\t\t$CTRL_C
REPL.activate(; interactive_utils=false)
println("done")
"""

Expand Down Expand Up @@ -159,6 +170,7 @@ function repl_workload()
occursin(HELP_PROMPT, strbuf) && break
sleep(0.1)
end
notify(repl_init_event)
check_errors(strbuf)
end
write(debug_output, "\n#### COMPLETED - Closing REPL ####\n")
Expand Down