Skip to content

LAPACK: Avoid repr call in chkvalidparam #54952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2024
Merged

LAPACK: Avoid repr call in chkvalidparam #54952

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3431c7b
LAPACK: Avoid repr call in chkvalidparam
jishnub Jun 27, 2024
4a4e7da
Don't restrict to AbstractChar
jishnub Jun 27, 2024
1767c7b
update comment
jishnub Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stdlib/LinearAlgebra/src/lapack.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@ macro chkvalidparam(position::Int, param, validvalues)
:(chkvalidparam($position, $(string(param)), $(esc(param)), $validvalues))
end
function chkvalidparam(position::Int, var::String, val, validvals)
# mimic `repr` for chars without explicitly calling it
# This is because `repr` introduces dynamic dispatch
_repr(c::AbstractChar) = "'$c'"
_repr(c) = c
if val ∉ validvals
throw(ArgumentError(
lazy"argument #$position: $var must be one of $validvals, but $(repr(val)) was passed"))
lazy"argument #$position: $var must be one of $validvals, but $(_repr(val)) was passed"))
end
return val
end
Expand Down