Skip to content

RFC: set nospecialize on any unused argument #54668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

RFC: set nospecialize on any unused argument #54668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/method.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,10 +864,9 @@ JL_DLLEXPORT void jl_method_set_source(jl_method_t *m, jl_code_info_t *src)
for (j = 1; j < m->nargs && j <= sizeof(m->nospecialize) * 8; j++) {
jl_value_t *ai = jl_array_ptr_ref(src->slotnames, j);
if (ai == (jl_value_t*)jl_unused_sym) {
// TODO: enable this. currently it triggers a bug on arguments like
// ::Type{>:Missing}
//int sn = j-1;
//m->nospecialize |= (1 << sn);
// TODO: this should be done by lowering, rather than here
int sn = j-1;
m->nospecialize |= (1 << sn);
continue;
}
if (j <= 8) {
Expand Down
2 changes: 1 addition & 1 deletion stdlib/REPL/test/precompilation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if !Sys.iswindows()
# given this test checks that startup is snappy, it's best to add workloads to
# contrib/generate_precompile.jl rather than increase this number. But if that's not
# possible, it'd be helpful to add a comment with the statement and a reason below
expected_precompiles = 0
expected_precompiles = 1

n_precompiles = count(r"precompile\(", tracecompile_out)

Expand Down