inlining: remove unused allow_abstract::Bool keyword argument
#53601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Mar 5, 2024
vtjnash
added
the
compiler:optimizer
aviatesk
force-pushed
the
avi/rm-allow_abstract
branch
from
a7cff1b to
1f10af0
Compare
|
The previous inlining algorithm used it, but it seems like we don't use it anymore. |
|
AFAICT, not using that anymore is actually a bug in the current algorithm: #53600 (comment) |
aviatesk
force-pushed
the
avi/rm-allow_abstract
branch
2 times, most recently
from
9b0ea8d to
33da26a
Compare
aviatesk
force-pushed
the
avi/rm-allow_abstract
branch
from
33da26a to
7d8d913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.