Skip to content

Limit TimeType subtraction to AbstractDateTime #49805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Limit TimeType subtraction to AbstractDateTime #49805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32ed459
Limit TimeType subtraction to AbstractDateTime
baumgold May 13, 2023
ff6dbb3
fix stack overflow
baumgold Jun 24, 2023
9f36e5e
Merge branch 'master' into DateTime_subtraction
baumgold Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stdlib/Dates/src/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
# TimeType arithmetic
(+)(x::TimeType) = x
(-)(x::T, y::T) where {T<:TimeType} = x.instant - y.instant
(-)(x::TimeType, y::TimeType) = -(promote(x, y)...)
(-)(x::T, y::T) where {T<:AbstractDateTime} = x.instant - y.instant
(-)(x::AbstractDateTime, y::AbstractDateTime) = -(promote(x, y)...)

# Date-Time arithmetic
"""
Expand Down
6 changes: 0 additions & 6 deletions stdlib/Dates/test/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ using Dates
@test Dates.CompoundPeriod(a - b) == Dates.Hour(12)
end

@testset "TimeType arithmetic" begin
a = Date(2023, 5, 1)
b = DateTime(2023, 5, 2)
@test b - a == Day(1)
end

@testset "Wrapping arithmetic for Months" begin
# This ends up being trickier than expected because
# the user might do 2014-01-01 + Month(-14)
Expand Down