Fix show_unquoted invalidations
#47050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes about 1000 method invalidations for multiple separate packages. The following table lists the number of invalidations on Julia 1.8.2, Julia nightly and this PR: Name | 1.8.2 | 1.9.0-DEV.1506 | This PR --- | --- | --- | --- CSV | 3173 | 5452 | 4560 CategoricalArrays | 3482 | 4713 | 3668 InlineStrings | 1376 | 654 | 654 ProgressLogging | 246 | 2990 | 2049 Generated with: ```julia using Pkg Pkg.activate(; temp=true) Pkg.add(["SnoopCompileCore", "SnoopCompile", "InlineStrings"]) using SnoopCompileCore invs = @Snoopr using InlineStrings using SnoopCompile trees = invalidation_trees(invs) print('\n', trees, '\n') @show length(invs) ``` and running the various Julia versions with `--startup-file=no`. Note that this PR reverts a change introduced by JuliaLang#44500. It changes a `convert(String, X)` back to `string(X)`. Based on this PR reverting an earlier PR and the seemingly random increases and decreases in the table, adding invalidations tests should help avoid regressions (JuliaLang#47022). I'll see whether I can find time to work on that.
|
Closing in favor of #47093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes about 1k method invalidations on Julia nightly for multiple separate packages. The following table lists the number of invalidations on Julia 1.8.2, Julia nightly and this PR:
Generated with:
and running for various packages and Julia versions with
--startup-file=no.Note that this PR reverts a change introduced by #44500. It changes a
convert(String, X)back tostring(X).Based on this PR reverting an earlier PR and the seemingly random increases and decreases in the table, adding invalidations tests should help avoid regressions (#47022). I'll see whether I can find time to work on that.
cc: @timholy, @ranocha
I suggest the
latencylabel.