set number of openblas threads to 1 while precompiling #46792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/openblas_precompile
branch
from
76b5914 to
f5594cf
Compare
28 tasks
staticfloat
reviewed
Sep 16, 2022
KristofferC
force-pushed
the
kc/openblas_precompile
branch
2 times, most recently
from
54efe79 to
4cb4b61
Compare
KristofferC
force-pushed
the
kc/openblas_precompile
branch
from
4cb4b61 to
70520cf
Compare
|
Do you think it’s worthwhile to force Julia to one thread as well? |
staticfloat
approved these changes
Sep 19, 2022
I don't actually know. And Julia is by default 1 thread. I'll leave it at this for now to get this in and we can think more about the julia thread case. |
KristofferC
added a commit
that referenced
this pull request
Sep 20, 2022
(cherry picked from commit b6d2434)
PallHaraldsson
added a commit
to PallHaraldsson/julia
that referenced
this pull request
Sep 30, 2022
This seems like a sensible followup to JuliaLang#46792 It's untested, I just used the github editor... and I don't know the optimal value, this just seemed sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the increased number of openblas threads by defaults, there have been reports about various types of crashes when precompilation is done in parallel. Limit the number of openblas threads during precompilation to reduce resource usage slightly.