Skip to content

Conversation

@oscardssmith
Copy link
Member

@oscardssmith oscardssmith commented Sep 14, 2022

I have no idea why this ended up here. mea culpa. Hopefully this can make it into 1.8.2

@oscardssmith oscardssmith added performance Must go faster maths Mathematical functions labels Sep 14, 2022
@oscardssmith oscardssmith changed the title I have no idea why this ended up here. Remove @noinline from tab_unpack Sep 14, 2022
@oscardssmith oscardssmith added this to the 1.8 milestone Sep 14, 2022
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 14, 2022
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Sep 14, 2022
@KristofferC
Copy link
Member

More descriptive commit message would be good.

@Keno Keno merged commit 6e4cf29 into backports-release-1.8 Sep 15, 2022
@Keno Keno deleted the oscardssmith-remove-noinline-from-tab_unpack branch September 15, 2022 00:07
@Keno
Copy link
Member

Keno commented Sep 15, 2022

I fixed up the commit message in the squash merge.

@oscardssmith oscardssmith removed this from the 1.8 milestone Sep 15, 2022
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Sep 15, 2022
@KristofferC KristofferC mentioned this pull request Sep 16, 2022
28 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maths Mathematical functions performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants