add warning for function declaration with undefined static parameter #46608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #27813 (does not fix it)
KristofferC
pushed a commit
that referenced
this pull request
Sep 7, 2022
28 tasks
This was referenced Sep 8, 2022
maleadt
pushed a commit
to JuliaGPU/CUDA.jl
that referenced
this pull request
Sep 8, 2022
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
This was referenced Sep 8, 2022
This was referenced Sep 9, 2022
domluna
pushed a commit
to domluna/JuliaFormatter.jl
that referenced
this pull request
Sep 12, 2022
Unbound type parameters cause performance issues. Issue found using JuliaLang/julia#46608
thchr
added a commit
to thchr/SnoopCompile.jl
that referenced
this pull request
Sep 20, 2022
On Julia master, JuliaLang/julia#46608 gave rise to a precompilation warning for SnoopCompile: ```jl julia> using SnoopCompile [ Info: Precompiling SnoopCompile [aa65fe97-06da-5843-b5b1-d5d13cad87d2] WARNING: method definition for precompilable_time at /home/tchr/.julia/packages/SnoopCompile/J3dtR/src/parcel_snoopi_deep.jl:290 declares type variable T but does not use it. ```
This was referenced Sep 20, 2022
jkrumbiegel
pushed a commit
to jkrumbiegel/GridLayoutBase.jl
that referenced
this pull request
Oct 1, 2022
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
|
Looks like this was missing a NEWS entry? Pretty visible change that is probably somewhat confusing to a lot of folks, because very-downstream packages see it. (but I am glad to have the warning, I bet with it many of these will be cleaned up very quickly). |
pkofod
pushed a commit
to JuliaNLSolvers/NLSolversBase.jl
that referenced
this pull request
Nov 21, 2022
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
pkofod
pushed a commit
to JuliaNLSolvers/Optim.jl
that referenced
this pull request
Nov 23, 2022
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
jverzani
pushed a commit
to jverzani/AMRVW.jl
that referenced
this pull request
Dec 14, 2022
I didn't check, but unbound type parameters can be serious performance bugs. Found with JuliaLang/julia#46608
maleadt
pushed a commit
to JuliaGPU/CUDA.jl
that referenced
this pull request
Jan 5, 2023
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
maleadt
pushed a commit
to JuliaGPU/CUDA.jl
that referenced
this pull request
Jan 6, 2023
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
simonbyrne
pushed a commit
to simonbyrne/CUDA.jl
that referenced
this pull request
Nov 13, 2023
Unbound type parameters often cause performance issues and run time dispatch. Issue found using JuliaLang/julia#46608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #27813 (does not fix it)
n.b. The change is very simple (just adding the
jl_has_typevarcall), but I had to shift around a lot of other code to make it so I had access to the file/line/name variables here for the warning message, so the diff is a big mess.Includes a fix for #42594 detected by this change during the sysimg build.
n.b. this emits a few warnings in the tests, since we have a couple existing tests that explicitly try this