run ;cmd through a shell
#4635
Merged
run ;cmd through a shell
#4635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any performance implications? For example, the time it takes to start up the shell? |
|
It seems reasonably fast to me and since it's a strictly interactive feature, if it feels fast enough, it is fast enough. |
|
This appears like it will be horrifically broken on Windows. |
|
Ah, that's a good point. I guess on Windows since there's no shell, we can just skip this. |
|
This is so much nicer than the old behavior, I just have to merge this. Supporting shell variable interpolation strikes me as unimportant since any programming with variables should probably be done in Julia land instead. |
StefanKarpinski
added a commit
that referenced
this pull request
Oct 25, 2013
run `;cmd` through a shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like this behavior a lot better – it behaves like your shell, which is really much nicer. If people like this, I think we should do it. There is a remaining issue with it, however, which is that there's no way to use shell variables.