some precompilation improvements #43415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Dec 13, 2021
aviatesk
reviewed
Dec 14, 2021
JeffBezanson
force-pushed
the
jb/precompile2
branch
from
023fd08 to
5d38e08
Compare
aviatesk
approved these changes
Dec 16, 2021
|
Needs rebasing. |
JeffBezanson
force-pushed
the
jb/precompile2
branch
from
5d38e08 to
3f6abcf
Compare
|
Looks like this PR broke llvmpasses: https://buildkite.com/julialang/julia-master/builds/6711#d4da1755-9ff3-4b86-8757-5df8a72a5d96 This is entirely my fault. I disabled Buildkite commit statuses while I work to move the Buildkite folder to a separate repo (https://github.com/JuliaCI/julia-buildkite). As soon as that work is done, I'll re-enable Buildkite commit statuses. |
vtjnash
added a commit
that referenced
this pull request
Sep 1, 2022
Added in #43415, this was too aggressive for many cases. Unlike the comment suggested, it is unneeded in many cases, so only do it when it is expected to be maximally profitable. julia> @time norm(C_212) before 45.959497 seconds (81.85 M allocations: 6.976 GiB, 6.31% gc time, 100.00% compilation time) after 15.781804 seconds (20.81 M allocations: 1.294 GiB, 6.32% gc time, 100.00% compilation time)
vtjnash
added a commit
that referenced
this pull request
Sep 1, 2022
Added in #43415, this was too aggressive for many cases. Unlike the comment suggested, it is unneeded in many cases, so only do it when it is expected to be maximally profitable. Fixes #46492 julia> @time norm(C_212) before 45.959497 seconds (81.85 M allocations: 6.976 GiB, 6.31% gc time, 100.00% compilation time) after 15.781804 seconds (20.81 M allocations: 1.294 GiB, 6.32% gc time, 100.00% compilation time)
vtjnash
added a commit
that referenced
this pull request
Sep 2, 2022
…#46581) Added in #43415, this was too aggressive for many cases. Unlike the comment suggested, it is unneeded in many cases, so only do it when it is expected to be maximally profitable. Fixes #46492 ``` julia> @time norm(C_212) before 45.959497 seconds (81.85 M allocations: 6.976 GiB, 6.31% gc time, 100.00% compilation time) after 15.781804 seconds (20.81 M allocations: 1.294 GiB, 6.32% gc time, 100.00% compilation time) ```
aviatesk
pushed a commit
that referenced
this pull request
Sep 9, 2022
…#46581) Added in #43415, this was too aggressive for many cases. Unlike the comment suggested, it is unneeded in many cases, so only do it when it is expected to be maximally profitable. Fixes #46492 ``` julia> @time norm(C_212) before 45.959497 seconds (81.85 M allocations: 6.976 GiB, 6.31% gc time, 100.00% compilation time) after 15.781804 seconds (20.81 M allocations: 1.294 GiB, 6.32% gc time, 100.00% compilation time) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably be kept as 2 separate commits.
The first commit makes sure compilation signatures (e.g. for nospecialize or varargs) are inferred eagerly, which we didn't always do before. Increases the system image by 4-5%, but that's probably a good thing since it means we are precompiling more code that is hopefully useful.
The second commit adds some missing precompile statements from
--trace-compile, in particular functions using the const_return calling convention (which don't need to be compiled at all, but we do need to know about them). That's not a big deal normally, but it's needed to make --strip-ir work in more cases. In any case, the printed trace is not really specific to compilation but to tell us which signatures arose that we could not figure out in advance.