Skip to content

fix #42245, export jl_setjmp on windows #42267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix #42245, export jl_setjmp on windows #42267

merged 1 commit into from
Sep 16, 2021

Conversation

JeffBezanson
Copy link
Member

fix #42245

@JeffBezanson JeffBezanson added embedding Embedding Julia using the C API bugfix This change fixes an existing bug labels Sep 15, 2021
@JeffBezanson JeffBezanson added this to the 1.7 milestone Sep 15, 2021
@KristofferC KristofferC mentioned this pull request Sep 16, 2021
Merged
84 tasks
@vtjnash vtjnash merged commit c5f3487 into master Sep 16, 2021
@vtjnash vtjnash deleted the jb/fix42245 branch September 16, 2021 15:09
@vtjnash vtjnash mentioned this pull request Sep 16, 2021
Merged
KristofferC pushed a commit that referenced this pull request Sep 23, 2021
@JeffBezanson @KristofferC
export jl_setjmp on windows (#42267)
f6e3388 
fix #42245

(cherry picked from commit c5f3487)
KristofferC pushed a commit that referenced this pull request Sep 28, 2021
@JeffBezanson @KristofferC
export jl_setjmp on windows (#42267)
b03841b 
fix #42245
@JeffBezanson JeffBezanson added the backport 1.6 Change should be backported to release-1.6 label Dec 6, 2021
@JeffBezanson JeffBezanson mentioned this pull request Dec 6, 2021
Closed
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@JeffBezanson @LilithHafner
export jl_setjmp on windows (JuliaLang#42267)
620967b 
fix JuliaLang#42245
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@JeffBezanson @LilithHafner
export jl_setjmp on windows (JuliaLang#42267)
491440e 
fix JuliaLang#42245
@KristofferC
Copy link
Member

Needs a manual backport against backports-release-1.6.

@Taaitaaiger Taaitaaiger mentioned this pull request May 13, 2022
Closed
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug embedding Embedding Julia using the C API
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

jl_setjmp is not exported on Windows, making it impossible to use the JL_TRY/JL_CATCH macros when embedding Julia
3 participants
@JeffBezanson @KristofferC @vtjnash