Skip to content

Disallow rem(x, y::Unsigned, RoundUp) #39318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disallow rem(x, y::Unsigned, RoundUp) #39318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40f79a4
Disallow rem(x, y::Unsigned, RoundUp)
sostock Jan 19, 2021
e21e32f
Merge branch 'master' into unsigned_rem_roundup
vtjnash Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions base/div.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ rem(x, y, r::RoundingMode)
rem(x, y, ::RoundingMode{:ToZero}) = rem(x, y)
rem(x, y, ::RoundingMode{:Down}) = mod(x, y)
rem(x, y, ::RoundingMode{:Up}) = mod(x, -y)
rem(x, y::Unsigned, ::RoundingMode{:Up}) =
throw(ArgumentError("rem(x, y, RoundUp) cannot be used with unsigned y")) # issue #34325
rem(x, y, r::RoundingMode{:Nearest}) = x - y * div(x, y, r)
rem(x::Integer, y::Integer, r::RoundingMode{:Nearest}) = divrem(x, y, r)[2]

Expand Down
7 changes: 7 additions & 0 deletions test/numbers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,6 +1751,13 @@ end
@test rem(typemin(T), T(-1)) === T(0)
@test mod(typemin(T), T(-1)) === T(0)
end
@testset "issue #34325" for S in (Int8, Int16, Int32, Int64, Int128)
U = unsigned(S)
@test rem(S(10), S(7), RoundUp) == -4
@test rem(U(10), S(7), RoundUp) == -4
@test_throws ArgumentError rem(S(10), U(7), RoundUp)
@test_throws ArgumentError rem(U(10), U(7), RoundUp)
end
end
@testset "issue #4156" begin
@test fld(1.4, 0.35667494393873234) == 3.0
Expand Down
Loading