Skip to content

Conversation

@staticfloat
Copy link
Member

This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as C:\.

This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as `C:\`.
@staticfloat staticfloat added backport 1.5 backport 1.6 Change should be backported to release-1.6 labels Dec 30, 2020
@staticfloat staticfloat requested a review from musm December 30, 2020 05:23
@musm
Copy link
Contributor

musm commented Dec 30, 2020

closes #38411, #38433

@musm
Copy link
Contributor

musm commented Dec 30, 2020

Now that chmod works more reliably, should we redo the reverted PR #38942 ? Ideally, we could instead patch libuv so that req->mode could be passed to work in the call to CreateDirectoryW in https://github.com/libuv/libuv/blob/v1.x/src/win/fs.c#L1217 .

@musm musm linked an issue Dec 30, 2020 that may be closed by this pull request
@musm musm linked an issue Dec 30, 2020 that may be closed by this pull request
@musm musm merged commit d46198d into master Dec 30, 2020
@musm musm deleted the sf/libuv_delete branch December 30, 2020 07:26
KristofferC pushed a commit that referenced this pull request Jan 5, 2021
This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as `C:\`.

(cherry picked from commit d46198d)
@KristofferC KristofferC mentioned this pull request Jan 5, 2021
26 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 6, 2021
staticfloat added a commit that referenced this pull request Jan 15, 2021
This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as `C:\`.

(cherry picked from commit d46198d)
@vchuravy vchuravy mentioned this pull request Jan 21, 2021
27 tasks
@vchuravy
Copy link
Member

@staticfloat can I trouble you with the backport of this for 1.5.4?

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as `C:\`.
staticfloat added a commit that referenced this pull request Dec 23, 2022
This bump to LibUV adds an important permission to files which should
allow them to be deleted more reliably when created in "system"-like
locations such as `C:\`.

(cherry picked from commit d46198d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.6 Windows permissions problems with *tmpdir* created dirs Permission errors for precompilation on Windows

5 participants