Improve optimizations on NULL pointer check #37114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark more functions and calls as non-null and use inbounds gep instead of integer arithmetics so that LLVM can more easily infer the non-null-ness of pointers. (Partially revert 2bb430e) Also add inline optimization for `ccall` on `jl_symbol_name` and makes sure the return value is treated as non-null by LLVM.
vtjnash
reviewed
Aug 19, 2020
| [](LLVMContext &C) { return AttributeList::get(C, | ||
| AttributeSet(), | ||
| Attributes(C, {Attribute::NoAlias, Attribute::NonNull}), | ||
| Attributes(C, {Attribute::NonNull}), |
Contributor
Author
There was a problem hiding this comment.
Oh yeah, this line of change is in principle a bug fix..... (commit was from a week ago and I've forgot about that...............)
Member
There was a problem hiding this comment.
Yeah, I think I missed the second half of the langref documentation for this attribute. (for arguments, it means that it doesn't alias any mutable memory, but for return values, it also means the pointer itself is unique à la malloc)
Contributor
Author
|
Back port label added for the single line change above to remove the incorrect return value attribute. (The back port should not use the commit message from this PR). |
Member
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
Mark more functions and calls as non-null and use inbounds gep instead of integer arithmetics so that LLVM can more easily infer the non-null-ness of pointers. (Partially revert 2bb430e) Also add inline optimization for `ccall` on `jl_symbol_name` and makes sure the return value is treated as non-null by LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark more functions and calls as non-null and use inbounds gep instead of integer arithmetics
so that LLVM can more easily infer the non-null-ness of pointers. (Partially revert 2bb430e)
Also add inline optimization for
ccallonjl_symbol_nameand makessure the return value is treated as non-null by LLVM.