make Profile more thread/signal-safe #37101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/signalsafe_profile
branch
3 times, most recently
from
12cf59a to
85c87a0
Compare
This hack, added in 7e95d09, was a workaround for LLVM3.3 not being able to generate binaries with the mandatory SEH section information. Now, it is just a potential source of segfaults in observation.
vtjnash
force-pushed
the
jn/signalsafe_profile
branch
from
85c87a0 to
b664ae3
Compare
Member
Author
|
Investigated the macOS hang overnight and tracked down the version of macOS that introduced that bug—let's see how this does now. |
Sacha0
added a commit
that referenced
this pull request
Oct 21, 2020
Sacha0
added a commit
that referenced
this pull request
Oct 22, 2020
Sacha0
added a commit
that referenced
this pull request
Oct 22, 2020
Sacha0
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally these codepaths contain an rwlock on every platform (or are specified that you should hold one). So this adds that lock, and additionally blocks signals on unix for extra protection against deadlock here.
Fixes #35117
Fixes #13294