Fix GC corruption during NamedTuple instantiation #36650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jul 14, 2020
vtjnash
reviewed
Jul 14, 2020
This code is dead, but also has GC-rooting issues (it modifies iparams with a newly allocated object, but iparams is not guaranteed to be roots). Delete it and add an assert that should fire if anybody ever changes the surrounding code to make it necessary again (at which point they can find this commit and fix it properly).
Otherwise it's illegal to hold onto this object without having set ->instance, which is just asking for crashes. Fixes #36649.
JeffBezanson
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a bonus missing GC root in dead code. Fixes #36649.