WIP: Test Harness & 32 Bit Issues #3447
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating julia today I noticed that 'make testall' was failing on my machine. The first two commits solve relatively minor issues that were likely overlooked due to the number of cores and 32/64 bit types of builds that are being tested more often. The reason I currently have this left as a WIP commit is that I assume the third commit should not be merged as is as it adds a conditional check to the binary shift operator which should not be needed.
I'm not quite too sure what the problem is with 128 bit shifts on my system, but it appears with both the included version of llvm and two recent (svn) images of llvm. Without the patch the behavior that makes some of the socket.jl tests fail is
With the patch, the bitshift by zero does what is expected.
Currently with this patchset applied all tests run cleanly on my Slackware Linux 14.0 32 bit system.