Document eltype for Random samplers, replace gentype. #32008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, in the Die example, define eltype from the beginning, instead of fixing it later, but mention what would happen if we didn't. Incidental typo fixes and clarifications.
This was referenced May 12, 2019
Closed
rfourquet
added
needs decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31968 by replacing Random.gentype with Base.eltype.
Also, in the Die example, define eltype from the beginning, instead of fixing it later, but mention what would happen if we didn't.
Incidental typo fixes and clarifications.