document Random samplers: continuation of #31787 #31990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in JuliaLang#31787.
it is just confusing at this stage.
Closed
rfourquet
reviewed
May 11, 2019
Member
rfourquet
left a comment
rfourquet
left a comment
There was a problem hiding this comment.
Thanks you for the updates, they look good, we are almost there now!
rfourquet
added
randomness
rfourquet
reviewed
May 11, 2019
|
|
||
| The object returned by `Sampler` is then used to generate the random values, by a method of `rand` defined for this purpose. Samplers can be arbitrary values, but for most applications the following predefined samplers may be sufficient: | ||
| The object returned by `Sampler` is then used to generate the random values. When implementing the random generation interface for a value `X::T` that can be sampled from, the implementor should define the method | ||
|
|
Member
There was a problem hiding this comment.
in X::T, the T is not used later right? then you could remove it (only if you push again to this branch for other reasons before we merge, no need to re-trigger CI only for this).
Contributor
Author
There was a problem hiding this comment.
I see no other outstanding changes, so I pushed a commit with this one. I am hoping the PR can be accepted now.
rfourquet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the overlooked issues in the discussion of #31787.
In addition, incidental clarifications and typo fixes.
@rfourquet