Fix initialization of accumulators in _generic_matmatmul! #27123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some redundant methods related to multiplication of Adjoint/Transpose Expand multi-line functions to multiple lines instead of using one-line syntax with ;s
andreasnoack
added
linear algebra
|
What exactly is the bugfix? It's hard for me to tell what the substantive changes are here among all of the formatting changes. |
Look at the changes to |
Liozou
pushed a commit
to Liozou/julia
that referenced
this pull request
May 24, 2018
…27123) Remove some redundant methods related to multiplication of Adjoint/Transpose Expand multi-line functions to multiple lines instead of using one-line syntax with ;s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some redundant methods related to multiplication of Adjoint/Transpose
Expand multi-line functions to multiple lines instead of using one-line
syntax with ;s
Update: In addition, I suspect that
_generic_matmatmul!and all themul!methods can be simplified quite a bit after #25558 lands.