Rename indmin and indmax to argmin and argmax #25654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
force-pushed
the
nl/argminmax
branch
2 times, most recently
from
75e7804 to
3517f4a
Compare
argmin and argmax match the mathematical names as well as those used by Numpy. On the contrary, there does not appear to be any precedent for indmin and indmax, and they do not follow any pattern in Julia either.
nalimilan
force-pushed
the
nl/argminmax
branch
from
3517f4a to
85892c1
Compare
ararslan
approved these changes
Jan 21, 2018
|
I proposed this a long time ago (and it was shot down at the time—on a phone, so it’s gard to find a link to the discussion). Very much approve! |
|
(Argh... I need to respond on a real keyboard!) |
|
@StefanKarpinski any opinion? I think we should do this. |
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argminandargmaxmatch the mathematical names as well as those used by Numpy. On the contrary, there does not appear to be any precedent forindminandindmax, and they do not follow any pattern in Julia either.