Add strides and stride deprecation to NEWS #25510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods themselves are still used and called, we just no longer provide a default implementation for all `AbstractArrays`
|
Thanks @dlfivefifty! I pushed a proposed change — feel free to edit/reject/counter if you don't like it. I think it'd be nice to clarify that the interface is still the same, it's just the generic implementation that is deprecated. |
fredrikekre
approved these changes
Jan 12, 2018
| * `findin(a, b)` has been deprecated in favor of `find(occursin(b), a)` ([#24673]). | ||
|
|
||
| * The generic implementations of `strides(::AbstractArray)` and `stride(::AbstractArray, ::Int)` | ||
| have been deprecated. Subtypes of `AbstractArray` that implement the newly introduced strided |
mbauman
added a commit
that referenced
this pull request
Jan 14, 2018
Fixes indentation mistake introduced in #25510 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates NEWS for the added strides and stride deprecation from pull request
#25321
as requested by @timholy.